Disallow read only users from performing writes to asset #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigincg
reviewed
Jun 10, 2024
| @@ -38,6 +44,16 @@ def test_create_asset(self): | |||
| response = self.client.post("/api/v1/asset/", sample_data) | |||
| self.assertEqual(response.status_code, status.HTTP_201_CREATED) | |||
|
|
|||
| def test_create_asset_read_only(self): | |||
There was a problem hiding this comment.
@rithviknishad Shouldn't we have tests for all ReadOnly Users?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2252 +/- ##
===========================================
+ Coverage 63.48% 63.52% +0.03%
===========================================
Files 238 238
Lines 13264 13276 +12
Branches 1886 1889 +3
===========================================
+ Hits 8421 8433 +12
Misses 4490 4490
Partials 353 353 ☔ View full report in Codecov by Sentry. |
sainak
approved these changes
Jul 10, 2024
vigneshhari
approved these changes
Jul 13, 2024
vigneshhari
deleted the
rithviknishad/fix/disable-asset-create-for-ro-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
Merge Checklist
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins