Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show IP/OP number in patients list page #7990

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Show IP/OP number in patients list page #7990

merged 3 commits into from
Jun 14, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

image image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner June 6, 2024 12:29
@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 11:50am

@rithviknishad rithviknishad added needs testing needs review P1 breaking issue or vital feature labels Jun 6, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 6, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 64f8011
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/666c2e4c747ffe00087c5f2f
😎 Deploy Preview https://deploy-preview-7990--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Jun 6, 2024 •
edited
Loading

Passing run #2753 ↗︎

0 124 0 0 Flakiness 0

Details:

Show IP/OP number in patients list page
Project: CARE Commit: 64f8011892
Status: Passed Duration: 03:15 💡
Started: Jun 14, 2024 11:54 AM Ended: Jun 14, 2024 11:57 AM

Review all test suite changes for PR #7990 ↗︎

@nihal467
Copy link
Member

@rithviknishad
image

IP# doesn't look good, can you think of a better UI

@rithviknishad
Copy link
Member Author

image

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b857722 into develop Jun 14, 2024
61 of 62 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/7977 branch June 14, 2024 13:00
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IP/OP number badge in the patient list tab
3 participants
@rithviknishad @nihal467 @khavinshankar