Add suggestion chips instead of autofilling diagnosis #8369

shivankacker · 2024-08-20T16:41:16Z

Clicking on a chip should autofill the diagnosis dropdown. The user will have to then select the type.
Also removes support for prescriptions as discussed on Weekly review (20th August)

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

vercel · 2024-08-20T16:41:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 23, 2024 7:22am

netlify · 2024-08-20T16:41:32Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`61691b3`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/66c83865eff9ab000837ccba
😎 Deploy Preview	https://deploy-preview-8369--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress · 2024-08-20T16:49:08Z

CARE Run #3173

Run Properties: Passed #3173 • 61691b3b33: Add suggestion chips instead of autofilling diagnosis

Project	`CARE`
Branch Review	`suggestion-chips`
Run status	`Passed #3173`
Run duration	`03m 01s`
Commit	`61691b3b33: Add suggestion chips instead of autofilling diagnosis`
Committer	`Shivank Kacker`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`126`
View all changes introduced in this branch ↗︎

github-actions · 2024-08-21T04:43:19Z

👋 Hi, @shivankacker,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

nihal467 · 2024-08-22T08:19:05Z

@shivankacker

can you clear the merge conflict
can you attach a screenshot or video about the feature
is it ready for testing ?

shivankacker · 2024-08-23T07:19:55Z

@nihal467 attached screenshots to the PR. It is ready to be tested.

nihal467 · 2024-09-02T10:15:58Z

@shivankacker

when we click on the suggestion chip of scribe, it entirely refresh the page, and all the scribe related data is vanished
modify the PR and issue description, mentioning is the chip clickable or not and what all other functionality are added / removed in the PR to have a better understanding on the context.

CC: @gigincg

netlify · 2024-09-02T12:26:04Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`9a8c481`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/66d73b644ca50500089ab596
😎 Deploy Preview	https://deploy-preview-8369--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shivankacker · 2024-09-02T12:27:57Z

@nihal467 updated, the buttons should be clickable and autofill the diagnosis dropdown

nihal467 · 2024-09-03T07:04:30Z

The badge is not accepting multiple clicks. For example, let's assume we have the badge 1A00 as shown in the screenshot. When we click on the badge, it auto-fills the diagnosis input field. However, if we remove it from the field and try to click on the badge again, the auto-fill for the diagnosis field will not work a second time.

When we add a particular diagnosis using the badge, the badge should be removed from the suggestions.

@shivankacker are these expected behaviors?

cc: @gigincg

…suggestion-chips

shivankacker · 2024-09-03T07:54:43Z

@nihal467 The bug with chip click has been fixed.

I did not hide already entered diagnoses as the Diagnosis dropdown also does not hide it, and it will throw the "Diagnosis already entered error" as well. Anyways I have hid it with the latest commit. But this might be a little confusing for a user who previously marked the diagnosis as entered in error and wishes to add it again. (Just an edge case)

nihal467 · 2024-09-03T08:09:30Z

@shivankacker the edge case seems valid, we shouldn't be hiding already-added badges for now, if user request for the same, we can do that

shivankacker · 2024-09-03T08:15:11Z

@nihal467 understood, reverted the change

nihal467 · 2024-09-03T09:19:30Z

LGTM

khavinshankar · 2024-09-03T09:52:55Z

src/Components/Diagnosis/ConsultationDiagnosisBuilder/AddICD11Diagnosis.tsx

@@ -36,6 +38,10 @@ export default function AddICD11Diagnosis(props: AddICD11DiagnosisProps) {
    }
  }, [res?.status]);

+  useEffect(() => props.prefill && setSelected(props.prefill), [props.prefill]);
+
+  useEffect(() => props.setPrefill?.(undefined), [selected]);


@shivankacker can we remove the second use effect and use a util function like handleSelection which updates both selected and prefill state

Made some changes, is that what you meant?

src/Components/Patient/DailyRounds.tsx

github-actions · 2024-09-03T18:47:05Z

@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Add suggestion chips instead of autofilling diagnosis

3583da0

shivankacker requested a review from a team as a code owner August 20, 2024 16:41

shivankacker added needs testing needs review labels Aug 20, 2024

vercel bot temporarily deployed to Preview August 20, 2024 16:42 Inactive

github-actions bot added the merge conflict pull requests with merge conflict label Aug 21, 2024

nihal467 added changes required and removed needs testing labels Aug 22, 2024

Fixed merge conflicts

4a9856d

github-actions bot removed the merge conflict pull requests with merge conflict label Aug 23, 2024

vercel bot temporarily deployed to Preview August 23, 2024 07:16 Inactive

shortfix

61691b3

shivankacker added needs testing and removed changes required labels Aug 23, 2024

vercel bot temporarily deployed to Preview August 23, 2024 07:22 Inactive

nihal467 added test failed and removed needs testing labels Sep 2, 2024

fixed onclick

7ef859f

shivankacker added needs testing and removed test failed labels Sep 2, 2024

Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …

73a3048

…suggestion-chips

nihal467 added test failed and removed needs testing labels Sep 3, 2024

Fix bug with chip click, and hid already entered diagnoses

e67d070

shivankacker added needs testing and removed test failed labels Sep 3, 2024

revert hiding already entered diagnosis

e4d66cb

nihal467 added tested and removed needs testing labels Sep 3, 2024

khavinshankar requested changes Sep 3, 2024

View reviewed changes

khavinshankar added the question Further information is requested label Sep 3, 2024

khavinshankar requested a review from rithviknishad September 3, 2024 09:53

rithviknishad requested changes Sep 3, 2024

View reviewed changes

src/Components/Patient/DailyRounds.tsx Show resolved Hide resolved

rithviknishad added changes required and removed needs review labels Sep 3, 2024

added onselect to AddICD11DiagnosisProps

9a8c481

shivankacker removed question Further information is requested changes required labels Sep 3, 2024

shivankacker requested review from khavinshankar and rithviknishad September 3, 2024 16:40

rithviknishad approved these changes Sep 3, 2024

View reviewed changes

khavinshankar approved these changes Sep 3, 2024

View reviewed changes

khavinshankar merged commit 5e95d60 into develop Sep 3, 2024
30 checks passed

khavinshankar deleted the suggestion-chips branch September 3, 2024 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add suggestion chips instead of autofilling diagnosis #8369

Add suggestion chips instead of autofilling diagnosis #8369

shivankacker commented Aug 20, 2024 •

edited

Loading

vercel bot commented Aug 20, 2024 •

edited

Loading

netlify bot commented Aug 20, 2024 •

edited

Loading

cypress bot commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 21, 2024

nihal467 commented Aug 22, 2024 •

edited by shivankacker

Loading

shivankacker commented Aug 23, 2024

nihal467 commented Sep 2, 2024 •

edited

Loading

netlify bot commented Sep 2, 2024 •

edited

Loading

shivankacker commented Sep 2, 2024

nihal467 commented Sep 3, 2024 •

edited

Loading

shivankacker commented Sep 3, 2024

nihal467 commented Sep 3, 2024

shivankacker commented Sep 3, 2024

nihal467 commented Sep 3, 2024

khavinshankar Sep 3, 2024 •

edited

Loading

shivankacker Sep 3, 2024

github-actions bot commented Sep 3, 2024

Add suggestion chips instead of autofilling diagnosis #8369

Add suggestion chips instead of autofilling diagnosis #8369

Conversation

shivankacker commented Aug 20, 2024 • edited Loading

Merge Checklist

vercel bot commented Aug 20, 2024 • edited Loading

netlify bot commented Aug 20, 2024 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

cypress bot commented Aug 20, 2024 • edited Loading

CARE Run #3173

github-actions bot commented Aug 21, 2024

nihal467 commented Aug 22, 2024 • edited by shivankacker Loading

shivankacker commented Aug 23, 2024

nihal467 commented Sep 2, 2024 • edited Loading

netlify bot commented Sep 2, 2024 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

shivankacker commented Sep 2, 2024

nihal467 commented Sep 3, 2024 • edited Loading

shivankacker commented Sep 3, 2024

nihal467 commented Sep 3, 2024

shivankacker commented Sep 3, 2024

nihal467 commented Sep 3, 2024

khavinshankar Sep 3, 2024 • edited Loading

Choose a reason for hiding this comment

shivankacker Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 3, 2024

shivankacker commented Aug 20, 2024 •

edited

Loading

vercel bot commented Aug 20, 2024 •

edited

Loading

netlify bot commented Aug 20, 2024 •

edited

Loading

cypress bot commented Aug 20, 2024 •

edited

Loading

nihal467 commented Aug 22, 2024 •

edited by shivankacker

Loading

nihal467 commented Sep 2, 2024 •

edited

Loading

netlify bot commented Sep 2, 2024 •

edited

Loading

nihal467 commented Sep 3, 2024 •

edited

Loading

khavinshankar Sep 3, 2024 •

edited

Loading