Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct i18n keys for daily rounds round type filter #8566

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner September 18, 2024 15:03
@rithviknishad rithviknishad added needs testing needs review P1 breaking issue or vital feature labels Sep 18, 2024
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit cbc76df
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66eaebd9a46e1f0008ef11c7
😎 Deploy Preview https://deploy-preview-8566--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Sep 18, 2024

CARE    Run #3394

Run Properties:  status check passed Passed #3394  •  git commit cbc76df55e: correct i18n keys for daily rounds round type filter
Project CARE
Branch Review rithviknishad/patch/fix-round-type-filter-i18n
Run status status check passed Passed #3394
Run duration 03m 10s
Commit git commit cbc76df55e: correct i18n keys for daily rounds round type filter
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 126
View all changes introduced in this branch ↗︎

@gigincg gigincg merged commit b9afa4a into develop Sep 18, 2024
28 checks passed
@gigincg gigincg deleted the rithviknishad/patch/fix-round-type-filter-i18n branch September 18, 2024 15:37
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review needs testing P1 breaking issue or vital feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily Rounds filter not in representable format for Community Nurses Log choice
2 participants