Edited the nursing care section to a table under nursing tab of patient #8579
+610
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for care-ohc pending review.Visit the deploys page to approve it
|
rithviknishad
requested changes
Sep 21, 2024
Comment on lines
+74
to
+80
| const groupedByDate: any = {}; | ||
| dataToDisplay.forEach((item: any) => { | ||
| if (!groupedByDate[item.date]) { | ||
| groupedByDate[item.date] = []; | ||
| } | ||
| groupedByDate[item.date].push(item); | ||
| }); |
There was a problem hiding this comment.
Can we keep the logic too similar to what's present in the Routine table at least?
Ideally let's have a reusable component for this, as it could be re-used in couple of other places as well eventually.
Let's also avoid the usage of any
rithviknishad
requested changes
Sep 21, 2024
There was a problem hiding this comment.
Also discard changes made to the lockfile.
|
Also, not all tasks mentioned in the issue is solved. Drop a comment once ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist