Skip to content

Conversation

@dilithjay
Copy link
Contributor

Closes #103

  • Add test for parse_with_schema function
  • Support openai o-series models by removing max_tokens param
  • Add support for providing example values or alternate keys for parse_with_schema function

@dilithjay dilithjay requested a review from Copilot November 17, 2025 14:32
Copilot finished reviewing on behalf of dilithjay November 17, 2025 14:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses schema-parsing functionality improvements by adding test coverage for parse_with_schema, adding support for OpenAI's o-series models by removing unsupported parameters, and introducing optional example_schema and alternate_keys parameters to guide the parsing process.

Key changes:

  • Added a new test for the parse_with_schema function with a sample schema
  • Modified LLM parameter handling to support o-series models by conditionally removing max_tokens and temperature
  • Extended parse_with_schema to accept optional example_schema and alternate_keys parameters for improved parsing guidance

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
tests/test_parser.py Added test coverage for parse_with_schema function with schema validation
lexoid/core/parse_type/llm_parser.py Updated model detection logic to exclude unsupported parameters for o-series models
lexoid/api.py Enhanced parse_with_schema with optional example schema and alternate keys support, added textwrap import

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pramitchoudhary pramitchoudhary added the dev Related to general dev tasks label Nov 19, 2025
@dilithjay dilithjay merged commit 5d1d1d7 into main Nov 23, 2025
3 checks passed
@dilithjay dilithjay deleted the dj/schema-todos branch November 23, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev Related to general dev tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema parsing to-dos

3 participants