-
Notifications
You must be signed in to change notification settings - Fork 10
Schema-parsing todos #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema-parsing todos #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses schema-parsing functionality improvements by adding test coverage for parse_with_schema, adding support for OpenAI's o-series models by removing unsupported parameters, and introducing optional example_schema and alternate_keys parameters to guide the parsing process.
Key changes:
- Added a new test for the
parse_with_schemafunction with a sample schema - Modified LLM parameter handling to support o-series models by conditionally removing
max_tokensandtemperature - Extended
parse_with_schemato accept optionalexample_schemaandalternate_keysparameters for improved parsing guidance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| tests/test_parser.py | Added test coverage for parse_with_schema function with schema validation |
| lexoid/core/parse_type/llm_parser.py | Updated model detection logic to exclude unsupported parameters for o-series models |
| lexoid/api.py | Enhanced parse_with_schema with optional example schema and alternate keys support, added textwrap import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Closes #103