Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit test coverage for four core Z-machine classes. The changes enable unit testing by setting the WITH_UNIT_TESTS flag in class metadata files and introduce test classes for the Z-machine, text encoding/decoding, stack operations, and memory management.
- Enabled unit testing for zmachine, text, stack, and memory classes
- Added 246 lines of tests for zmachine covering initialization, execution flow, and I/O
- Added 229 lines of tests for text encoding/decoding with alphabet validation
- Added 310 lines of tests for stack operations including nested calls and frame isolation
- Added 268 lines of tests for memory operations and header parsing
- Enabled local_testclass_consistency linting rule
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/zork_00/zcl_ork_00_zmachine.clas.xml | Enabled unit testing flag for zmachine class |
| src/zork_00/zcl_ork_00_zmachine.clas.testclasses.abap | Added 8 test methods covering zmachine initialization, execution, input handling, and output management |
| src/zork_00/zcl_ork_00_text.clas.xml | Enabled unit testing flag for text class |
| src/zork_00/zcl_ork_00_text.clas.testclasses.abap | Added 6 test methods for text encoding/decoding including alphabet validation and dictionary encoding |
| src/zork_00/zcl_ork_00_stack.clas.xml | Enabled unit testing flag for stack class |
| src/zork_00/zcl_ork_00_stack.clas.testclasses.abap | Added 11 test methods for stack operations including push/pop, local variables, nested calls, and frame isolation |
| src/zork_00/zcl_ork_00_memory.clas.xml | Enabled unit testing flag for memory class |
| src/zork_00/zcl_ork_00_memory.clas.testclasses.abap | Added 11 test methods for memory operations including header parsing, byte/word read/write, and global variables |
| abaplint.jsonc | Added local_testclass_consistency linting rule |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
success, 
|
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 beep beep