Merge pull request #12 from oiwn/dev

fix memory usage calculation
oiwn · Jan 6, 2025 · a2d8380 · a2d8380
2 parents 8660e77 + e5a6136
commit a2d8380
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -43,6 +43,10 @@ name = "bloom-server"
 path = "src/bin/server.rs"
 required-features = ["server", "redb"]
 
+[package.metadata.docs.rs]
+no-default-features = true
+features = ["redb"]
+
 [features]
 default = ["redb", "server"]
 redb = ["dep:redb"]

diff --git a/README.md b/README.md
@@ -131,9 +131,11 @@ Memory usage is calculated as:
 
 ```
 total_bits = capacity * max_levels
-memory_bytes = total_bits / 8
+memory_bytes = total_bits * 8
 ```
 
+Since i use `u8` to store `bool`.
+
 ## Contributing
 
 Contributions are welcome! Please feel free to submit a Pull Request. For major changes, please open an issue first to discuss what you would like to change.

diff --git a/src/bin/server.rs b/src/bin/server.rs
@@ -47,7 +47,7 @@ async fn main() {
     // Calculate the memory usage estimation
     let bits_per_level = filter_config.capacity;
     let total_bits = bits_per_level * filter_config.max_levels;
-    let estimated_memory_kb = (total_bits as f64 / 8.0 / 1024.0).ceil();
+    let estimated_memory_kb = (total_bits as f64 * 8.0 / 1024.0).ceil();
 
     info!(
         r#"