Skip to content

Dependency upgrades - #316

Draft
BenjaminTruong-okta wants to merge 7 commits into
masterfrom
dependency-upgrades
Draft

Dependency upgrades#316
BenjaminTruong-okta wants to merge 7 commits into
masterfrom
dependency-upgrades

Conversation

@BenjaminTruong-okta

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

Root's resolutions applied @types/react/@types/react-dom pins
monorepo-wide via yarn resolutions, silently overriding v6-app's
explicit React 18 types with React 16 even though nohoist gave it a
separate node_modules copy. These pins are unnecessary in devDependencies
too: @types/react's major/minor is tied to the real react package it
targets, so the existing ^16.9.0 range already can't drift past major 16.

Also drop @types/enzyme, picomatch, and cheerio resolutions pins added
by the previous commit: @types/enzyme and cheerio already resolved to
the pinned versions naturally, so the pins were no-ops, and the
picomatch pin was forcing a consumer that requested ^4.x down to 2.3.1
for no evidenced reason. Only @types/node is kept, since it prevents
two coexisting major versions from producing duplicate ambient type
declarations under strict tsc.
Rollup toolchain (Batch B): rollup 2->4, @rollup/plugin-babel 5->7,
@rollup/plugin-replace 2->6, rollup-plugin-typescript2 0.29->0.37.
Updates rollup.config.js for Rollup 4's native ESM config loading
(JSON import, typescript import) and restores the AUTH_JS min-version
replacement broken by @rollup/plugin-replace v6's stricter default
delimiters.

Isolated majors (Batch C): compare-versions 4->6, dotenv 8->17 (root
and env workspace), rimraf 2->6, shelljs 0.8->0.10.

Verified via yarn build/lint/test:unit and a manual login/logout
click-through on test/apps/v6-app against a real Okta org.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant