Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for more commands #323

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Add support for more commands #323

wants to merge 24 commits into from

Conversation

henrikwidlund
Copy link
Contributor

Commands added:

  • Dimmer Control
  • Channel Level Control
  • Audio Delay Control
  • Dirac Filter Control
  • Eco Mode Control
  • Audyssey LFC Control
  • HDMI Output Control
  • Status Display

@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch 2 times, most recently from c0515b6 to dd2097a Compare March 9, 2025 15:55
@henrikwidlund
Add support for more commands
66586a4 
Commands added:
- Dimmer Control
- Channel Level Control
- Audio Delay Control
- Dirac Filter Control
- Eco Mode Control
- Audyssey LFC Control
- HDMI Output Control
- Status Display
- Surround Mode Next/Previous
@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch 2 times, most recently from 12217e4 to 66586a4 Compare March 9, 2025 16:03
@henrikwidlund
Copy link
Contributor Author

@ol-iver what should I do about the problems with Literal in the tests? Replace them with Enum?

@ol-iver
Copy link
Owner

ol-iver commented Mar 16, 2025

@ol-iver what should I do about the problems with Literal in the tests? Replace them with Enum?

I'll remove support for python 3.7. It is EOL anyway.

@henrikwidlund
Copy link
Contributor Author

Damnit, I missed your comment and now I pushed the changes. Do you want me to revert it?

@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch from b1a19cc to 43fe7c3 Compare March 16, 2025 17:50
@henrikwidlund henrikwidlund force-pushed the feature/more_commands branch from 43fe7c3 to 01f8b79 Compare March 16, 2025 17:52
@henrikwidlund
Copy link
Contributor Author

If anyone had any doubts, the number of commits to fix linting should tell you that I'm not a Python developer 😅

@ol-iver
Copy link
Owner

ol-iver commented Mar 16, 2025 •
edited
Loading

Damnit, I missed your comment and now I pushed the changes. Do you want me to revert it?

Please give it a try 👍
I just removed Python 3.7 in main branch.

@henrikwidlund
Copy link
Contributor Author

henrikwidlund commented Mar 16, 2025 •
edited
Loading

Damnit, I missed your comment and now I pushed the changes. Do you want me to revert it?

Please give it a try 👍 I just removed Python 3.7 in main branch.

Done. Just realized that I could create literals in the const file to not have to duplicate the definitions, that would also work for the channel enum, but I'm not sure about that one as the channel names are a bit hard to understand the acronyms, that's the reason I chose to use enums for those two types, DimmerMode is kind of understandable I guess.

@henrikwidlund
Copy link
Contributor Author

Okay, I converted everything to literals, still not sure about the channels though.

@henrikwidlund
Copy link
Contributor Author

henrikwidlund commented Mar 17, 2025 •
edited
Loading

@ol-iver okay, I think I'm done with this one now 😅
I looked into having update functionality for the Dirac filter as well as map the names of the profiles, but it's not available in the app, so not sure it's possible yet, ot least it will be very difficult to reverse engineer it. The command /goform/formiPhoneAppDirect.xml?PSDIRAC%20? doesn't return anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrikwidlund @ol-iver