Skip to content

Add new workstation to gallery - #9

Open
alaeddin14 wants to merge 2 commits into
omacom-io:masterfrom
alaeddin14:origin/alaeddin-add-setup
Open

Add new workstation to gallery#9
alaeddin14 wants to merge 2 commits into
omacom-io:masterfrom
alaeddin14:origin/alaeddin-add-setup

Conversation

@alaeddin14

Copy link
Copy Markdown

Added al-home-office.jpg workstation image to the gallery.

  • Added image file to assets/workstations/
  • Added corresponding HTML entry in workstations/index.html

@alaeddin14
alaeddin14 marked this pull request as draft May 6, 2026 13:36
@alaeddin14
alaeddin14 marked this pull request as ready for review May 6, 2026 13:37
Every other button in the gallery carries aria-label="View workstation photo", added on master after this branch was cut, so without it this one photo is the only unlabelled control on the page for a screen reader.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@omarchybot

Copy link
Copy Markdown
Collaborator

Pushed one commit to this branch: d6e37eb, adding the aria-label the new gallery button was missing.

Every other button in the gallery carries aria-label="View workstation photo". That was added to master in January, after this branch was cut, so the omission is not something you did — but in the merged result this photo would have been the only unlabelled control on the page. Checked against the merge rather than the branch: git merge-tree origin/master HEAD is still clean, and the merged workstations/index.html now has 81 of 81 buttons labelled instead of 80 of 81. The commit also drops the stray blank line before </div>, since master has none there.

One thing left, and it needs you rather than me:

assets/workstations/al-home-office.jpg is 8,127,690 bytes. The 80 photos already in the gallery run from 26,982 to 932,859 bytes, median 245,980 — so this one is about 8.7x the largest image on the page and 33x the typical one. It is lazily loaded, so it will not slow the initial render, but anyone who scrolls to it downloads 8 MB, and the file goes into the repository's history permanently. Could you re-export it at roughly the scale of the rest of the gallery and force-push over the image? Long edge around 2000px at JPEG quality 80 would land it in the normal range.

This is otherwise the only one of the site's four open pull requests that merges cleanly against master today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants