You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewed this from the Linux side, since that is the platform anyone here can actually test. Short version: the Linux build, the tests and every documented Linux shortcut survive intact, and the two things worth flagging are small.
Verified on a clean Arch box with Qt 6.11.1:
./bin/test passes — 13 tests, including the new detectsSystemAppearanceWithoutRequiringAPortal. ./bin/build still produces build/omawrite, so the literal install -Dm755 build/omawrite in pkgbuild/PKGBUILD is unaffected by the new VERSION = 0.1.0.
The brew branches in bin/build and bin/test never run on Linux. I put a brew on PATH that touches a marker file and rebuilt; the marker was never created, because elif stops at qmake6 and the later conditions — including the $(brew --prefix qtbase) substitution — are never evaluated.
JOBS cannot come out empty: on Linux sysctl -n hw.logicalcpu exits 1 and prints nothing to stdout, so || echo 1 wins and make -j never runs unbounded.
linux: QT += dbus matches on Arch — the link line pulls in libQt6DBus.so — and moc still sees Q_OS_LINUX through qmake's moc_predefs.h, so handlePortalSettingChanged is present in the generated meta-object and the portal SettingChanged connection still binds. Live theme and text-size changes keep working.
The StandardKey conversions keep every binding the README documents. QKeySequence::keyBindings(QKeySequence::Redo) on Qt 6.11.1 is Ctrl+Y | Alt+Shift+Backspace | Ctrl+Shift+Z | Redo under every keyboard scheme I tried, and sequences: grabs all of them, so Ctrl+Y still redoes. Side effect worth knowing about: StandardKey.Undo and StandardKey.Redo also bind Alt+Backspace and Alt+Shift+Backspace now.
Two things for you:
src/Main.qml:361 — Shortcut.nativeText returns only the first entry of sequences, so the fullscreen row of the Ctrl+? dialog now reads Meta+F Fullscreen where it used to read F11 / Super+F Fullscreen. F11 still works, it is just no longer discoverable from the dialog, and Meta is not what an Omarchy user calls that key. Left it alone rather than picking a wording for you, but that row wants spelling out on the Linux branch.
pkgbuild/Info.plist replaces Qt's generated plist wholesale and drops NSPrincipalClass (NSApplication), which Qt's own mkspecs/macx-clang/Info.plist.app template sets. No Mac here to check on, so this is a question rather than a claim: did you confirm the bundle activates and gets its menu bar without it? The same file hardcodes 0.1.0 where @SHORT_VERSION@ would track VERSION in omawrite.pro, so the two will drift at the next release.
One scheduling note: PRs #14, #15, #17 and #18 all touch src/Main.qml, and #15 and #17 add rows to the same shortcuts dialog this rewrites — whichever lands second will need a rebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.