Skip to content

Fix Copilot platform payload cleanup - #214

Open
jeremydixon22 wants to merge 1 commit into
omacom:masterfrom
jeremydixon22:fix/copilot-platform-cleanup
Open

Fix Copilot platform payload cleanup#214
jeremydixon22 wants to merge 1 commit into
omacom:masterfrom
jeremydixon22:fix/copilot-platform-cleanup

Conversation

@jeremydixon22

@jeremydixon22 jeremydixon22 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This fixes the dead cleanup block identified in #195. _moddir currently points at the package root, while the prebuild and platform payloads being pruned live under node_modules/@github/copilot-linux-${_arch}. Pointing _moddir at that actual payload root makes the existing cleanup operations effective.

The change is kept separate from #195 as requested there: it does not alter arch=(). If #195 lands first, this branch will need a small rebase because both changes touch the same PKGBUILD and carry separate durable AUR patches.

Verification:

  • built github-copilot-cli 1.0.80-1.1 successfully in archlinux:base-devel
  • confirmed the package contains no Darwin, Windows, or ARM64 platform payloads on the x86_64 build
  • ran the staged CLI and confirmed version 1.0.80
  • replayed the pinned AUR source through bin/package-worktree; patched/ matches current/
  • separately confirmed the overlay applies to the pinned raw recipe with patch --dry-run --fuzz=0
  • passed omarchy-pkgs self-test, omarchy-release self-test, and package-scoped edge and stable release dry-runs in the Arch environment

@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown

Greptile Summary

The PR repairs GitHub Copilot CLI package cleanup by rebasing _moddir onto the architecture-specific platform payload before existing pruning operations run.

  • Bumps the local package revision to publish the corrected package.
  • Adds the same cleanup-path correction as a durable patch that survives AUR synchronization.
  • Keeps architecture declarations unchanged.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The new payload root matches the directory containing the files being pruned, the package revision is advanced, and the durable patch has been verified against the pinned upstream recipe under strict application semantics.

Important Files Changed

Filename Overview
pkgbuilds/github-copilot-cli/PKGBUILD Correctly redirects existing cleanup operations to the nested native platform package and bumps the package revision.
pkgbuilds/github-copilot-cli/.omarchy/patches/0001-fix-platform-payload-cleanup.patch Durably reproduces the cleanup-path correction during AUR synchronization, with strict replay verification reported.

Reviews (1): Last reviewed commit: "Fix Copilot platform payload cleanup" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant