fix(update): guard confirm_reboot in omarchy-update-restart under unattended runs - #9100
Open
harshithnadig wants to merge 1 commit into
Open
Conversation
When running 'omarchy update -y', OMARCHY_UPDATE_UNATTENDED=1 is exported so that update steps run without waiting for interactive input. However, confirm_reboot() previously called 'gum confirm' unconditionally if the kernel, hyprland, or state files indicated a reboot was needed, causing unattended updates to hang. Check OMARCHY_UPDATE_UNATTENDED and report that a reboot is pending instead of prompting interactively. Fixes omacom#9079
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In #9079, running
omarchy update -yin unattended mode can still hang on interactive input if the Linux kernel, Hyprland binary, orreboot-requiredstate file is present.While
omarchy-updateexportsOMARCHY_UPDATE_UNATTENDED=1on-y,confirm_reboot()inbin/omarchy-update-restartwas callinggum confirm "$1"unconditionally without an unattended check.Solution
Check
${OMARCHY_UPDATE_UNATTENDED:-}inconfirm_reboot(). When unattended, log the reboot notification and return without blocking, allowing the remaining update and shell reload steps to complete cleanly.Fixes #9079