fix(bindings): mirror RETURN bindings to KP_Enter - #9107
Open
harshithnadig wants to merge 1 commit into
Open
Conversation
Keyboards on certain laptops (and external numpads) emit KP_Enter (keysym 0xff8d) for their Enter key rather than Return. Because Omarchy application bindings in 'applications.lua' and capture bindings in 'utilities.lua' were only bound to 'RETURN', pressing Enter on affected keyboards did not match any shortcuts. Mirror 'RETURN' bindings to 'KP_Enter' across application launchers and region capture overlay. Fixes omacom#9030
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In #9030, certain laptops (and full-size keyboards with numpads) emit
KP_Enter(evdevKEY_KPENTER96, keysym0xff8d) for their Enter key rather thanReturn.Because Omarchy's application and capture bindings in
default/hypr/bindings/were only declared forRETURN, shortcuts likeSUPER + Enter(Terminal),SUPER + SHIFT + Enter(Browser),SUPER + ALT + Enter(Tmux), andSUPER + CTRL + Enter(Herdr) never matched.Solution
Mirror the
RETURNkeybindings toKP_Enterin:default/hypr/bindings/applications.lua(Terminal, Browser, Tmux, Herdr)default/hypr/bindings/utilities.lua(Slurp region capture overlay)Fixes #9030