fix(brightness): pass target monitor to DPMS dispatch in omarchy-brightness-display - #9108
Open
harshithnadig wants to merge 1 commit into
Open
Conversation
…htness-display 'omarchy-brightness-display' accepts '--monitor <name>' and defaults to the focused monitor, but the 'off' and 'on' branches dispatched global DPMS actions without specifying the monitor key, causing a single blanking command to turn off all connected displays. Pass 'monitor = "$monitor"' to 'hl.dsp.dpms' when targeting a specific output for off/on actions. Fixes omacom#9077
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In #9077, running
omarchy brightness display --monitor <output> offblanks all connected monitors instead of only the specified display.Cause
bin/omarchy-brightness-displayparses and resolves$monitor, but theoffandonbranches dispatched globalhl.dsp.dpms({ action = "disable" })calls without passing themonitorparameter.Solution
Pass
monitor = "$monitor"intohl.dsp.dpmsso that DPMS disable/enable calls target the requested monitor output, consistent withomarchy-hyprland-monitor-clamshell.Fixes #9077