fix(monitor): detect stranded outputs with no active scanout in omarchy-hyprland-monitor-modeless - #9110
Open
harshithnadig wants to merge 1 commit into
Open
Conversation
…hy-hyprland-monitor-modeless
'omarchy-hyprland-monitor-modeless' only checked whether an enabled monitor
had .width == 0 or .height == 0. When an output drops link during an atomic
commit (or loses its CRTC after DPMS off), it retains a valid mode in
'hyprctl monitors all' but is unassigned and absent from active scanout
('hyprctl monitors'), causing the recovery loop in 'monitor-watch' to abort
prematurely and leave the screen black.
Compare active scanout outputs with all connected outputs to detect
unassigned/stranded enabled monitors alongside 0x0 mode monitors.
Fixes omacom#9078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In #9078,
omarchy-hyprland-monitor-modelessonly checks if.width == 0 or .height == 0.When an external output drops link during an atomic commit or loses its CRTC, it reports a valid mode in
hyprctl monitors all -jbut is absent from actively scanned-out displays inhyprctl monitors -j. Because the query returned1("recovered"), the recovery loop inomarchy-hyprland-monitor-watchexited immediately, leaving the monitor dark indefinitely.Solution
Compare actively scanned-out outputs against
hyprctl monitors allto detect enabled non-mirrored outputs that have dropped scanout alongside 0x0 modes.Fixes #9078