Reset media marquee label when the scroll animation stops - #9120
Open
ya-luotao wants to merge 1 commit into
Open
Reset media marquee label when the scroll animation stops#9120ya-luotao wants to merge 1 commit into
ya-luotao wants to merge 1 commit into
Conversation
A stopped NumberAnimation leaves x wherever the marquee was, so a title that fits (or the label under an open popup) could be parked outside the clip and the widget rendered as a blank gap next to the play glyph. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RrGftF1S6Xymu7Z58TRd3M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The media bar widget scrolls long titles with a
NumberAnimation on xinside a clipped 180px item. When the marquee stops — a short title that fits replaces a long one, the player goes away and comes back, the popup opens, or the bar goes vertical — Qt leavesxat the last interpolated value instead of restoring it. The label ends up parked partly or fully outside the clip, so exactly the titles that fit show up as an empty gap next to the play glyph (#8991).Fix
Reset
labelText.xto 0 fromscrollAnim'sonRunningChangedwhenever the animation stops. Every stop path flipsrunning, Qt stops the underlying job before emitting the signal, and the animation reseedsxfromfromwhen it restarts, so scrolling behaviour is unchanged. Five-line diff, no restructuring.Verification
test/shell.d/media-test.shandtest/shell.d/qml-text-format-test.shpass;bar-widget-contract-test.shskips without a compositor.omarchy-restart-shell.Fixes #8991
🤖 Generated with Claude Code
https://claude.ai/code/session_01RrGftF1S6Xymu7Z58TRd3M