Add Apple Silicon macOS support - #19
Conversation
|
Reviewed this from the Linux side, since that is the platform anyone here can actually test. Short version: the Linux build, the tests and every documented Linux shortcut survive intact, and the two things worth flagging are small. Verified on a clean Arch box with Qt 6.11.1:
Two things for you:
One scheduling note: PRs #14, #15, #17 and #18 all touch |
|
Tested this PR on an Apple Silicon Mac:
The PR successfully builds a native arm64 application bundle. After deployment and ad-hoc signing, I encountered two issues worth noting:
Overall, the macOS port itself works and the app runs well. |
The conversion to StandardKey.Redo silently dropped Ctrl+Y, which README.md still documents. Qt resolves StandardKey through the platform theme's keyboard scheme, and Omarchy's sessions export QT_QPA_PLATFORMTHEME=gtk3, so keyBindings(Redo) comes back as Ctrl+Shift+Z and the hardware Redo key with no Ctrl+Y. This is invisible to the test suite because bin/test runs offscreen, where the scheme resolves differently and Ctrl+Y is present -- measuring there says the binding survived when on a real desktop it did not. macOS keeps the plain standard key, since Qt maps Ctrl to Command there and Cmd+Y is not a redo shortcut. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-Authored-By: Codex XHigh <noreply@openai.com>
|
Re-reviewed after @stefan-ernst's macOS run. The head had not moved, so this is about that report plus one thing we got wrong last time. We were wrong about What hid it from us, and from the suite: That is worth knowing beyond this PR: no test run through Pushed On the macOS report. It is a genuine result and the first real evidence the port works, but it is one machine, and it is worth being precise about what it settles. It shows the branch compiles, deploys, signs and launches on macOS 15.7.3 arm64 with Homebrew Qt 6.11.1. It does not show the platform branches are maintainable, and nothing here can regress-test them — we have no Mac, so every macOS-only path in this PR is still unexecuted on our side.
Still open from last time. The fullscreen row of the Scheduling. The set of open PRs touching Reviewed by Claude Opus 5 and by Codex at xhigh reasoning. Codex raised the Whether Omarchy carries a second platform at all is still the maintainer's decision and not one we will make in either direction. Nothing in this review is a judgement on that; it is only what the code does on each side. |


No description provided.