You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Under the GTK platform theme, Qt Quick Dialogs uses a native GTK file chooser. On a 2x Wayland display, that chooser can restore a 1231x903 GTK geometry and open beyond the 1280x832 logical work area.
Force Omawrite Open and Save dialogs to use Qt Quick Dialogs built-in implementation. Its Material dialog has a 600x400 logical default and stays inside the application window instead of restoring GTK window geometry.
Add object names and a unit check that both dialogs set DontUseNativeDialog.
Verification
git diff --check
Compared the dialog behavior with the Qt 6.11.2 FileDialog documentation and Material implementation
Added usesQuickFileDialogs coverage
The test suite was not run because this environment lacks qmake and Qt development packages
Live verification on the reported 2x display is still needed
I reproduced this outside Omawrite with a standalone GTK 3 file chooser. GTK converts an already-computed CSS pixel font size by resolution / 72 a second time. That produces the 1203×902 default; removing the leftover conversion gives 880×660, and Omawrite's Qt+GTK path drops from 1231×950 to 908×707.
DontUseNativeDialog bypasses the faulty GTK path by replacing the native picker, so it should not be merged as the fix for this issue. A focused GTK fix is prepared and locally verified against GTK issue #4891. Please close this PR; I’ll link the upstream MR after it is submitted.
The upstream GTK fix is now available as GNOME/gtk!10311, with its full CI pipeline passing. The recommendation to close this draft in favor of addressing the GTK root cause is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<<<< AI wording below >>>>
Problem
Under the GTK platform theme, Qt Quick Dialogs uses a native GTK file chooser. On a 2x Wayland display, that chooser can restore a 1231x903 GTK geometry and open beyond the 1280x832 logical work area.
Reported in omacom/omarchy#9046.
Fix
Force Omawrite Open and Save dialogs to use Qt Quick Dialogs built-in implementation. Its Material dialog has a 600x400 logical default and stays inside the application window instead of restoring GTK window geometry.
Add object names and a unit check that both dialogs set
DontUseNativeDialog.Verification
git diff --checkusesQuickFileDialogscoverage