Don't convert records to maps when reading #551
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated this PR and resolved the conflicts with latest master. |
|
Why has this PR not been merged? Besides the merge conflict, are the problems with the implementation, or the effects on the rest of the codebase, or something else?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey David,
we discussed earlier today an issue about defrecords and
normalization. I first thought records in the state atom are converted
to maps during normalization. This is not the case. I was using pprint
and didn't realize that records are printed as regualar maps.
However, the records are turned into maps while reading them. I think
the problem is in the
path-metafunction and the use of(into {} ...).I added a test case to demonstrate the issue, and added a case for
records in the
path-metafn. However I'm not quite sure ifpath-metashould stop at a record (as I do now), or continue as inthe map case. Btw.
(empty record)does not work.Feedback welcome!
Roman