Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OM 877 - Fix db->tree recursive join query on vector value #878

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bnoguchi
Copy link
Contributor

See GH-877:

In JVM clojure, the following will fail:

(let [query [{:tree [:id
                         :value
                         {:children '...}]}]
          state {:tree {:id 0 :value 42
                        :children [{:id 1 :value 43
                                    :children [{:id 2 :value 99
                                                :children []}]}
                                   {:id 3 :value 101
                                    :children []}]}}]
      (is (= state
             (om/db->tree query state state))))

with exception

java.lang.IllegalArgumentException: Don't know how to create ISeq from: clojure.lang.Symbol

@bnoguchi bnoguchi changed the title Fix OM 877 - Fix db->tree recursive edge case Fix OM 877 - Fix db->tree recursive join query on vector value Jul 10, 2017
@swannodette
Copy link
Member

@bnoguchi thanks, have you submitted your Om Contributor Agreement? If not I can send it to your preferred email, thanks!

@bnoguchi
Copy link
Contributor Author

@swannodette I haven't signed the Om Contributor Agreement, but happy to review and sign today. I'll DM you on Slack with my preferred email. Thanks, and great work on all the new goodies in Clojurescript!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants