fix: open Zed on Windows by direct spawn instead of zed:// URL - #589
Open
Oct1AtJoe wants to merge 1 commit into
Open
fix: open Zed on Windows by direct spawn instead of zed:// URL#589Oct1AtJoe wants to merge 1 commit into
Oct1AtJoe wants to merge 1 commit into
Conversation
Zed on Windows does not correctly handle zed://file/C:/path URLs.
When DSH hands such a URL to rundll32, Zed launches but refuses
to open the file (os error 123 - invalid filename).
Changes:
- src/client/open-with.ts: normalizeUrlPath now uses encodeURI()
to properly percent-encode spaces and special characters.
- src/open-external.ts:
- findZedPath: scan filesystem and PATH first via existsSync();
registry execSync is the last resort.
- zedUrlToPath: strip prefix, decodeURI, remove leading slash
from URL parsers (/C:/ -> C:), normalize to Windows backslashes.
- urlCommand: on win32+zed://, spawn the discovered zed.exe
with the native file path directly instead of rundll32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Zed on Windows does not correctly handle
zed://file/C:/pathURLs. When DSH hands such a URL to rundll32, Zed launches but refuses to open the file (os error 123 - invalid filename).Changes
src/client/open-with.ts:normalizeUrlPathnow usesencodeURI()to properly percent-encode spaces and special characters.src/open-external.ts:findZedPath: scan filesystem and PATH via fastexistsSync()first; registryexecSyncfallback as last resort (reliable under DSH sandbox).zedUrlToPath: stripzed://file/prefix, decodeURI, remove leading slash from URL parsers (/C:/?C:), convert to native Windows backslashes.urlCommand: onwin32+zed://, spawn the discoveredzed.exewith the native file path directly instead ofrundll32.