fix(lifecycle): surface idle review failures - #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要 / Summary
Failed idle reviews now appear in the Memory System workspace and Host log. The warning survives ordinary conversation turns until a successful review or session reset, and context-window errors explain how to choose a compatible task model.
关联 Issue 或背景 / Related Issue or Context
Fixes #210
涉及区域 / Affected Areas
PR 类型 / PR Type
最新代码确认 / Latest Codebase Confirmation
main分支开发,或在提交前已 rebase 或合并最新main。 / I developed from the latestmain, or rebased or merged the latestmainbefore submitting.同步命令 / Sync command:
git fetch origin main; based on1e19caf(latestorigin/main).AI 编码披露 / AI Coding Disclosure
使用的 AI 模型 / AI model used:
GPT-6 Astra, max reasoning.
使用的编码 Agent 工具 / Coding Agent tool used:
Codex desktop with an isolated issue worktree.
仓库规范检查 / Repository Rules
@deepseek-ai/*NPM 契约。 / I did not modify DSH source or point tsconfig at a DSH source checkout, and used only published@deepseek-ai/*NPM contracts.src/host/protocol.ts为准,没有在两侧重复定义 wire DTO。 / The Client and Host boundary still uses browser-safesrc/host/protocol.tsas the source for wire DTOs.lib/文件。 / I did not commit tokens, credentials, private memory, unredacted logs, or generatedlib/files.兼容性与数据安全 / Compatibility and Data Safety
Uses the existing status DTO and published DSH contracts. Fork parent-context inheritance and candidate eligibility are preserved. Errors are bounded to 500 characters with existing-style API-key redaction; no transcripts are included. No persistence format, Provider authority, configuration key or stored-memory migration changes; rollback needs no data conversion. The warning is visible when workspace status loads or refreshes and does not wake the parent model.
本地验证 / Local Validation
执行的命令 / Commands run:
结果摘要 / Result summary:
Passed
pnpm run verify(930 root tests, 5 expected skips),pnpm verify:plugins(16 independent repositories, 17 artifacts), the opt-in real Mnemon 0.2.7 create/write/recall/forget test, documentation validation andgit diff --check. Regression tests failed before the change. Real WebUI fault injection ran with all three Strategy enhancements; an ordinary runtime write succeeded afterward. The controlled endpoint exercises the actual HTTP400/fork path without a paid API or a synthetic 145K-token payload. A composition follow-up verifies HTTP 200 for parent requests that advertise the stable result tool, while stable and legacy child completion personas receive HTTP 400.用户可见变更证据 / Local Feature Evidence
证据 / Evidence:
Reproduction and bilingual evidence