Skip to content

[API] generate a typed client for AcceleratorClass - #688

Merged
pallasathena92 merged 1 commit into
mainfrom
yifeliu/fix-ac-client
Aug 3, 2026
Merged

[API] generate a typed client for AcceleratorClass#688
pallasathena92 merged 1 commit into
mainfrom
yifeliu/fix-ac-client

Conversation

@pallasathena92

@pallasathena92 pallasathena92 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

What this PR does

AcceleratorClass was missing the +genclient marker, so client-gen never produced a typed client, lister, or informer for it — the only one of the eight root API types affected.

Why we need it

The consequence was visible in the generated tree — pkg/client/clientset/versioned/typed/ome/v1beta1/ had a file for all seven other types and none for AcceleratorClass. Consumers had to fall back to the dynamic client or controller-runtime.

What Changes

AcceleratorClass is cluster-scoped, so +genclient alone would generate a namespaced client — it would compile fine and then fail at runtime against a cluster-scoped resource. so add +genclient:nonNamespaced as well

Two incidental tidy-ups:

  • removed a blank line that separated the marker block from type AcceleratorClass struct (which is what let this slip past a marker scan in the first place)
  • normalized scope=Clusterscope="Cluster" to match the other cluster-scoped types.
    Fixes #

How to test

Checklist

  • Tests added/updated (if applicable)
  • Docs updated (if applicable)
  • make test passes locally

@github-actions github-actions Bot added api API/Types changes in pkg/apis dependencies Dependency updates labels Jul 31, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Pre-commit checks failed

Please run the following locally and commit the fixes:

pre-commit run --all-files
git add -u && git commit

See CONTRIBUTING.md for setup instructions.

@pallasathena92
pallasathena92 force-pushed the yifeliu/fix-ac-client branch from 0300422 to 6f61833 Compare July 31, 2026 18:28
@pallasathena92
pallasathena92 merged commit 75346b1 into main Aug 3, 2026
14 checks passed
@pallasathena92
pallasathena92 deleted the yifeliu/fix-ac-client branch August 3, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API/Types changes in pkg/apis dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants