Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor --initdb --upgradedb arguments (IDR-0.4.0) #104

Merged
merged 3 commits into from
Jun 14, 2017

Conversation

manics
Copy link
Member

@manics manics commented Jun 12, 2017

Follow-on from #103

Replaces the separate init_db upgrade_db methods in omego {install,upgrade}with a singlehandle_database` method that deals with the logic required for handling intersecting flags.

Also adds -v ON_ERROR_STOP=on to all psql calls

Proposed tag: 0.6.1 (0.6.2 to follow with gh-95)

@manics manics changed the title Refactor --initdb --upgradedb arguments Refactor --initdb --upgradedb arguments (IDR-0.4.0) Jun 12, 2017
@sbesson sbesson modified the milestone: 0.6.1 Jun 13, 2017
@joshmoore
Copy link
Member

@manics : did you look into testing the return codes in this PR?

@manics
Copy link
Member Author

manics commented Jun 13, 2017

I didn't

@joshmoore
Copy link
Member

I'm not successfully getting the exit codes via $? that you've shown here. I'm merging this as 0.6.1 to allow Seb's work to continue and have filed #106 so we can come back to tests for this.

@joshmoore joshmoore merged commit 134d4a2 into ome:master Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants