-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep 5.8.4 #416
Prep 5.8.4 #416
Conversation
jburel
commented
Dec 15, 2023
- Bump dependencies
- Add changelog
Conflicting PR. Removed from build OMERO-insight-push#299. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-insight-push#300. See the console output for more details.
|
Looks good to me. Any idea why the build is failing? Also a bit worried that the merge-ci build doesn't work (strangely local gradle build does). |
the build was failing because artifacts.openmicroscopy.org was down due to the power outage |
@dominikl
Everything works as expected. |
What @dominikl is meaning is (i.e. grab the build from jenkins, which has to be started using bash as well, but fails as below)
@jburel I have successfully repeated your workflow with release artifacts from GitHub - it very much resembles my workflow ^^^ except that the zip is from Jenkins in my case. The only difference thereafter is the result - the Github release artifact just works, the CI artifact from jenkins does not. |
It does not work from merge-ci sorry I forgot to mention it in my testing report |
👍 Any idea how we could fix the msi installer issue? #400 . I guess that will be bigger effort to find out what's going wrong there, right? |
CHANGELOG.md
Outdated
@@ -1,3 +1,22 @@ | |||
5.8.4 (January 2024) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5.8.4 (January 2024) | |
5.8.4 (May 2024) |
Looks good. Just release date 'January' should be updated to 'May' :-) |