Adjust the upload and download of artifacts v4 #448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is trying to address #447
This branch starts from the https://github.com/ome/omero-insight/actions/runs/10884718399 - the commit a3ea82d -> where the build started to fail because of the same-named artifacts.
The strategy taken:
Upload:
matrix.os
motif to the artifact name -> this is by itself not enough, as we build 2 artifacts per OS on 2 occassionsomero_
which is taken from the foldername of thepath
variable just below thename
of the artifactDownload:
file: artifacts/*
->file: artifacts*/*
so that the artifacts are found in all folders created during Upload.I have pushed an xxx-test8 tag to my private branch show-tagged-artifacts (because I do not want to push tags to this branch so as not to trigger a real release) and this resulted in Release with artifacts
cc @jburel