Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the upload and download of artifacts v4 #448

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

pwalczysko
Copy link
Member

@pwalczysko pwalczysko commented Sep 19, 2024

This is trying to address #447

This branch starts from the https://github.com/ome/omero-insight/actions/runs/10884718399 - the commit a3ea82d -> where the build started to fail because of the same-named artifacts.

The strategy taken:

Upload:

  1. add the matrix.os motif to the artifact name -> this is by itself not enough, as we build 2 artifacts per OS on 2 occassions
  2. add a hardcoded string such as omero_ which is taken from the foldername of the path variable just below the name of the artifact

Download:

  1. adjust the file: artifacts/* -> file: artifacts*/* so that the artifacts are found in all folders created during Upload.

I have pushed an xxx-test8 tag to my private branch show-tagged-artifacts (because I do not want to push tags to this branch so as not to trigger a real release) and this resulted in Release with artifacts

cc @jburel

@pwalczysko
Copy link
Member Author

I have pushed an xxx-test8 tag to my private branch show-tagged-artifacts (because I do not want to push tags to this branch so as not to trigger a real release) and this resulted in Release with artifacts

@jburel
Copy link
Member

jburel commented Sep 19, 2024

Tested on my account. Everything works as expected
Thanks @pwalczysko

@jburel jburel merged commit 5750f8f into ome:master Sep 19, 2024
8 checks passed
@pwalczysko pwalczysko deleted the fix-gha branch September 19, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants