Fix the failure of the test_cleanse.py#6462
Open
pwalczysko wants to merge 2 commits into
Open
Conversation
Member
|
Thanks, @pwalczysko. No immediate objections from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The failing test is https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/11/testReport/junit/OmeroPy.test.integration.clitest.test_cleanse/TestCleanseFullAdmin/testCleanseNonsenseName/
This PR is removing a line in the
test_cleanse.py.The assertion in that line which checks the existence of a path to a logfile which should have been deleted is not possible on NFS, because:
As the Blitz process is still holding the logfile open, on NFS this file cannot be deleted by NFS although the
cleansescript deletes it - it leaves a hidden file behind which the NFS renames to...nfs.Testing this PR
Check that the Jenkins build testintegration job is green.
Related reading
See #6461
cc @joshmoore @jburel @sbesson