Skip to content

Fix also the test_remove__pre_fs_pyramids#6465

Open
pwalczysko wants to merge 2 commits into
ome:developfrom
pwalczysko:test_remove__pre_fs_pyramids
Open

Fix also the test_remove__pre_fs_pyramids#6465
pwalczysko wants to merge 2 commits into
ome:developfrom
pwalczysko:test_remove__pre_fs_pyramids

Conversation

@pwalczysko

@pwalczysko pwalczysko commented Jul 15, 2026

Copy link
Copy Markdown
Member

What this PR does

Fixes https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/lastCompletedBuild/testReport/OmeroPy.test.integration.clitest.test_pyramids/TestRemovePyramidsFullAdmin/test_remove__pre_fs_pyramids/

  • The main fix is necessary because the Image which has been imported has no StatsInfo, i.e. setting the True to False in the following block (preventing the copying of the non-existent Statsinfo) was necessary:
new_img = pixels_service.copyAndResizeImage(
                orig_pix.image.id.val, rint(4000), rint(4000), rint(1),
                rint(1), [0], None, False).val

Further, there was a second copy of the image which was inserting Pixels. This was crashing as the Pixels were not produced in time (again, NFS effect). So removed the line self.copyPixels(...)

Testing this PR

See if the Jenkins build passes.

@pwalczysko

pwalczysko commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

This seems to have failed in build 18 on Jenkins (it was passing on previous builds where this fix was included).
The build 18 was run without the OmeroJava which preceeds the OmeroPy suite.

Not sure why the failure happened exactly in build 18, not before.... seems pretty random.

Nevertheless, should we not simply drop testing removal of pre-fs stuff ? cc @will-moore @jburel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant