Fix test_remove_pyramids_check_thumbs NFS#6466
Open
pwalczysko wants to merge 1 commit into
Open
Conversation
…n: necessary for NFS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/lastCompletedBuild/testReport/OmeroPy.test.integration.clitest.test_pyramids/TestRemovePyramidsFullAdmin/test_remove_pyramids_check_thumbnails/
Adds the
waits _for_pyramid_filein 2 places and waits for thumbs deletion: necessary for NFS. The test was suffering from race problems in 3 places. The pyramids have to beAll 3 actions ^^ are slower on NFS and the necessary checks were added here so that the test can go ahead smoothly.
Testing this PR
Check that Jenkins is green.
Note: This was tested as passing in the Jenkins env itself (but the test was edited and triggered manually).
Related reading
Similar to #6464, but a bit more complex, as this
...check_thumbnailstest is multi-staged.