Fix test_render_image_region_tile_params_big_image#6469
Open
pwalczysko wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes
test_render_image_region_tile_params_big_image, see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/lastCompletedBuild/testReport/OmeroWeb.test.integration.test_rendering/TestRenderImageRegion/test_render_image_region_tile_params_big_image/ which is consistently failing (also as a single test on the new merge-ci) withomero.MissingPyramidException: exception ::omero::MissingPyramidExceptionThe fix is to wait until the pyramid is renderable. There is an explicit loop now which is polling for a pyramid renderable by the RenderingEngine.
Testing this PR
Check merge-ci,
test/integration/test_rendering.py::TestRenderImageRegion::test_render_image_region_tile_params_big_imageRelated reading
Similar (but with different method, the "wait until file is on disk" is not working here, it must be renderable) to #6464
Necessary after move to NFS.
cc @jburel @will-moore