Fix for getRelativeURL & URI character coercer#12
Open
eblondel wants to merge 2 commits intoomegahat:masterfrom
Open
Fix for getRelativeURL & URI character coercer#12eblondel wants to merge 2 commits intoomegahat:masterfrom
eblondel wants to merge 2 commits intoomegahat:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @duncantl, here's a proposal of fix for
getRelativeURL& the setAs character method for URI objects. I've raised issues while doing attempts to parse local XSD schemas (schemas from https://github.com/eblondel/geometa/tree/master/inst/extdata/schemas) with the XMLSchema package. The issues were:getRelativeURL: handling with relative paths with../occurences was not working, leading to bad handling of XSD imports/includes.Thanks in advance if you can review this, and hopefully merge it if code is fine.