Skip to content

fish-shell 4 : add new recipe #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fish-shell 4 : add new recipe #1675

wants to merge 1 commit into from

Conversation

@extrowerk
Copy link
Contributor

@extrowerk extrowerk commented Nov 1, 2025

@extrowerk extrowerk changed the title Fish-shell 4.0.6 added Fish-shell 4.x added Nov 4, 2025
hadfl
hadfl reviewed Nov 4, 2025
View reviewed changes
Copy link
Member

@hadfl hadfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. There are a few nits (see below).

On top, can you please add the package to doc/packages.md as well as doc/baseline

build/fish/build.sh
DESC="friendly interactive shell"

SKIP_SSP_CHECK=1
SKIP_LICENCES=COPYING
Copy link
Member

@hadfl hadfl Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the licence is GPLv2 like stated in local.mog can the pattern in doc/licences be adjusted to parse it properly than just "skipping" it?

Copy link
Contributor Author

@extrowerk extrowerk Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't fully GPLv2 : https://github.com/fish-shell/fish-shell/blob/master/COPYING
How should I handle this?

@extrowerk
Copy link
Contributor Author

extrowerk commented Nov 5, 2025

Thank you for your contribution. There are a few nits (see below).

On top, can you please add the package to doc/packages.md as well as doc/baseline

Done

@extrowerk
Copy link
Contributor Author

extrowerk commented Nov 13, 2025

Recipe updated to 4.2.0 using the patches from the OpenIndiana repo: https://github.com/OpenIndiana/oi-userland/tree/oi/hipster/components/shell/fish

@extrowerk extrowerk requested a review from hadfl November 13, 2025 07:17
@extrowerk extrowerk changed the title Fish-shell 4.x added fish-shell 4 : add new recipe Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@citrus-it citrus-it Awaiting requested review from citrus-it citrus-it is a code owner

@oetiker oetiker Awaiting requested review from oetiker oetiker is a code owner

@hadfl hadfl Awaiting requested review from hadfl hadfl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@extrowerk @hadfl