Cleanup lambda image stuff#10
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 8 8
Lines 306 306
=======================================
Hits 301 301
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a cleanup of the Lambda container image management modules by removing unused build arguments and renaming a module for better clarity.
Changes:
- Removed
build_argsparameter from thelambda-image-buildmodule as it's not currently needed - Renamed
lambda-containermodule tolambda-image-republishfor improved naming consistency - Updated all references in examples and documentation to reflect the module rename
Reviewed changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/lambda-image-republish/versions.tf | New file defining Terraform and AWS provider version constraints for the renamed module |
| modules/lambda-image-republish/variables.tf | New file defining input variables for image republishing functionality |
| modules/lambda-image-republish/outputs.tf | New file defining outputs including image URIs and repository details |
| modules/lambda-image-republish/main.tf | New file implementing ECR repository creation and Docker image republishing logic |
| modules/lambda-image-build/variables.tf | Removed unused build_args variable definition |
| modules/lambda-image-build/main.tf | Removed build_args logic and simplified the docker build command |
| examples/basic/variables.tf | Removed build_args variable from example |
| examples/basic/main.tf | Updated module source reference from lambda-container to lambda-image-republish and removed build_args parameter |
| PLAN.md | Updated module name references from lambda-container to lambda-image-republish in project plan |
| IDEA.md | Updated module name reference in usage example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ethanholz
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two main changes here:
build_argsfrom thelambda-image-buildmodule (no longer passing additional Docker args; at least, not until/unless needed)lambda-container->lambda-image-republish, which I think is both a more clear name, and also aligns better with thelambda-image-buildmodule name.