Fix problems with keychain#21
Merged
Merged
Conversation
I was occasionally getting failures when deploying images due to some repeat authorization in the keychain. This apparently fixes it.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses keychain credential helper conflicts that were causing occasional failures during Docker image deployment. The solution adds an ephemeral Docker configuration directory to isolate Docker credentials from the host system's keychain.
Changes:
- Introduced ephemeral DOCKER_CONFIG directory using
mktemp -dwith cleanup trap - Applied the same fix consistently across three Terraform modules that perform Docker operations
- Added inline comments documenting the purpose of the ephemeral configuration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| modules/lambda-image-republish/main.tf | Adds ephemeral Docker config before pulling from public ECR and pushing to private ECR |
| modules/lambda-image-public/main.tf | Adds ephemeral Docker config before building and pushing to public ECR |
| modules/lambda-image-build/main.tf | Adds ephemeral Docker config before building and pushing to private ECR |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@dwhswenson could you please provide a reference to where this was found? I am having trouble finding references for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was occasionally getting failures when deploying images due to some repeat authorization in the keychain. This apparently fixes it.