Add permissions for lambda downloads to containers#23
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ECR repository policies in the Lambda container image workflow so AWS Lambda can pull the image layers during cold starts.
Changes:
- Expanded the existing ECR repository policy in
lambda-image-republishto explicitly allow the Lambda service principal to pull images. - Added an ECR repository policy to
lambda-image-buildgranting account push/pull and Lambda image pull permissions. - Ensured the build/push step depends on the repository policy being applied.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/lambda-image-republish/main.tf | Adds a Lambda service principal pull statement to the destination ECR repository policy. |
| modules/lambda-image-build/main.tf | Introduces an ECR repository policy for the built image repository and wires it into dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like I'd left off some permissions that were needed for a (cold) lambda to pull down the image. Somehow the cron job worked for me once, but not the second time!