Skip to content

If install script installs a tag/branch/commit, pin workflows to that#21

Merged
dwhswenson merged 3 commits intoomsf:mainfrom
dwhswenson:add-pinned-installs
Jan 22, 2026
Merged

If install script installs a tag/branch/commit, pin workflows to that#21
dwhswenson merged 3 commits intoomsf:mainfrom
dwhswenson:add-pinned-installs

Conversation

@dwhswenson
Copy link
Member

Previously, the install script was just downloading the examples as of that commit. Now we pin usage to that as well.

Previously, the install script was just downloading the examples as of
that commit. Now we pin usage to that as well.
@dwhswenson dwhswenson requested a review from Copilot September 26, 2025 23:38
@github-actions
Copy link

github-actions bot commented Sep 26, 2025

This PR has been staged at https://f5d6677a.astro-site-testing.pages.dev.

It has been updated for commit e363674.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR enhances the install script to pin workflow references to the specified tag, branch, or commit being installed, ensuring consistency between the downloaded examples and their reusable workflow references.

  • Adds a new function update_reusable_workflow_references to pin workflow references after downloading
  • Updates the integration test to verify that workflow references are properly pinned
  • Improves shell script quoting and adds validation for pinned references

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
install.py Adds workflow reference pinning functionality and integrates it into the install process
test_install.py Adds comprehensive tests for the new pinning functionality and updates existing tests
test_install.sh Improves shell script with proper quoting and adds validation for pinned workflow references

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

This PR has been staged at https://4fa535a4.static-site-tools-testing.pages.dev.

It has been updated for commit e363674.

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

This PR has been staged at https://608f6a8f.jekyll-site-testing.pages.dev.

It has been updated for commit e363674.

dwhswenson and others added 2 commits September 26, 2025 18:42
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@ethanholz ethanholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, sorry I missed this!

@ethanholz
Copy link
Contributor

@dwhswenson do you want to merge this?

@dwhswenson
Copy link
Member Author

I had also completely forgotten about this! Thanks, and yeah, let's merge this in!

@dwhswenson dwhswenson merged commit af0f1f4 into omsf:main Jan 22, 2026
7 checks passed
@dwhswenson dwhswenson deleted the add-pinned-installs branch January 22, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants