Skip to content

Remove the Deprecated SSL ON directive from SSL config - #44

Closed
morrismukiri wants to merge 1 commit into
masterfrom
remove-ssl-on
Closed

Remove the Deprecated SSL ON directive from SSL config#44
morrismukiri wants to merge 1 commit into
masterfrom
remove-ssl-on

Conversation

@morrismukiri

Copy link
Copy Markdown
Contributor

Remove SSL on directive from template to allow use of listen 443 ssl;

Signed-off-by: Morris Mukiri <morrismukiri@gmail.com>
FrankApiyo added a commit that referenced this pull request Jun 30, 2026
The ssl on; directive it used to guard was removed (not valid in nginx 1.26),
leaving an empty {% if %}{% endif %} block. Remove the dead wrapper too.
Folds in #44.
@FrankApiyo

Copy link
Copy Markdown
Member

Closing as superseded by #43.

That branch already removes the deprecated ssl on; directive (commit 2c6433f, "Remove ssl on config as it's not valid in nginx 1.26") as part of the broader nginx 1.24+ / Ubuntu 22.04–26.04 modernization, and I've now folded in the rest of your cleanup there (commit 8b9015b) — removing the now-empty {% if site.server.ssl.add_ssl_directive %} … {% endif %} wrapper too, so nothing dangling is left behind.

Since both PRs edit the same lines of templates/secure_ssl.conf.j2, keeping them separate would just mean a rebase/conflict for whichever merges second. Thanks for catching this — the fix lives on in #43. 🙏

@FrankApiyo FrankApiyo closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants