refactor: idempotent role tasks + molecule idempotence gate - #64
Open
FrankApiyo wants to merge 4 commits into
Open
refactor: idempotent role tasks + molecule idempotence gate#64FrankApiyo wants to merge 4 commits into
FrankApiyo wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.custom_template_versionmarker in the release dir and only reruns the git surgery on change.docs.pipinstall moved from shell to thepipmodule (idempotent);make htmlguarded bycreates:on the built index; theln -sfnsasl2 shell (which crashes outright on ubuntu2204 — no/usr/lib64) replaced withfilemodule tasks that create the parent dir first.idempotencestep, resolves the role under test by path (stale~/.ansible/rolescopies no longer shadow the checkout), and testinfra asserts the versioned-release marker.Depends on onaio/ansible-django#52 —
molecule/default/requirements.ymltemporarily pinsonaio.djangoto its branch. Do not merge until #52 merges and the pin is bumped to the merged SHA.Test plan
molecule test(ubuntu2204) against the django feature branch: fresh converge, idempotence rerunchanged=0, testinfra 3/3molecule/default/requirements.ymlto the merged ansible-django SHAonadata_versionreports ~0 changesFollow-up (non-blocking):
Set custom template factsraises an opaque Jinja error ifonadata_custom_template_versionmatches no refs on the template repo — worth an explicit assert like the django role's version check.Note: CI on
masterhas been red since 2026-06-08 for unrelated reasons.