feat(encryption): add support for editing instances from encrypted form (Base 7.6.1) - #3
Open
kelvin-muchiri wants to merge 7 commits into
Open
feat(encryption): add support for editing instances from encrypted form (Base 7.6.1)#3kelvin-muchiri wants to merge 7 commits into
kelvin-muchiri wants to merge 7 commits into
Conversation
When editing an encrypted form without modifying media files, getCurrentFiles() returns string filenames for unchanged files instead of Blob objects. The encryptor requires Blobs for encryption. This adds _convertFilesToBlobs() which fetches the actual file data for string filenames before encryption, handling both data URIs and remote URLs, enabling submission of edited encrypted forms with unchanged media.
Pre-fetch all instance attachment URLs as Blobs when an encrypted form opens for editing, while the Redis cache is still fresh. This prevents 404s when the user takes longer than the 30s cache TTL before submitting. The prefetched Blobs are returned directly from getCurrentFiles(), removing the need for _convertFilesToBlobs in the encryptor and its circular fileManager import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.