Mirror intel/llvm commits #2769
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… OpenCL (#18423) Fixes #2440 [clEnqueueMemFillINTEL returns CL_INVALID_VALUE if dst_ptr is NULL, or if dst_ptr is not aligned to pattern_size bytes. ](https://registry.khronos.org/OpenCL/extensions/intel/cl_intel_unified_shared_memory.html) This PR adds a memory alignment check before calling `clEnqueueMemFillINTEL` to ensure we can safely call it, otherwise take the host side copy path. Re-enables the `USM/fill_any_size.cpp` and also moves `checkUSMImplAlignment` from Hip into a common header so it can be used in both Hip and OpenCL.
Hoists the `UUR_KNOWN_FAILURE_ON()` introduced in intel/llvm#18611 up to the test fixture to also cover `urEnqueueCommandBufferExpTest.SerializeAcrossQueues` in addition to `urEnqueueCommandBufferExpTest.SerializeOutofOrderQueue`.
Failing gtest doesn't fail right away. Wrap all calls to base class "SetUp" methods in the `UUR_RETURN_ON_FATAL_FAILURE` macro. This also includes cases where these functions were the last line in the function, making it a NFC, but updating those for consistency.
This reverts commit 44ed9b74e290bbd3a00575af974194c7b3d07e35, but excludes the problematic changes to jobs.
An initial implementation of urQueueGetInfo to help pass more e2e tests. Note that this PR does not yet address thread safety of the Queue API - this will be done in a subsequent PR. Fixes at least `Basic/in_order_queue_status_khr_empty.cpp` on NativeCPU.
When building UR tests in a dpcpp build (which is disabled by default), some warnings are flagged, which this patch fixes. Specifically: * Marking fixture functions as `override` where appropriate. * Removing casts `const char *` -> `void *`.
…aviour in code (#18652) Current documentation states the `UR_LAYER_FULL_VALIDATION ` env var enables `UR_LAYER_PARAMETER_VALIDATION` and `UR_LAYER_LEAK_CHECKING` but in the [code](https://github.com/intel/llvm/blob/375974ee85bef7e504550a0e7595d109bfe9bcd7/unified-runtime/source/loader/layers/validation/ur_valddi.cpp#L12313) it also enables `UR_LAYER_BOUNDS_CHECKING` and `UR_LAYER_LIFETIME_VALIDATION`.
github-actions
bot
force-pushed
the
mirror-commits-
branch
from
f0d7425 to
32bd595
Compare
github-actions
bot
added
ci/cd
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide will be updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be marked with the Should you wish to continue with your PR you will need to migrate it to intel/llvm. If your PR should remain open and not be closed automatically, you can remove the This is an automated comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action