Update xcframework zip file name #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contain `.xcframework` to make clear and allow Carthage to find the binary
ankushkushwaha
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2359
Contain
.xcframeworkto make clear and allow Carthage to find the binary.Now the pre-built xcframeworks files includes the
xcframeworkin the file name in the release page.Kingfisher-${version}.zipKingfisher-${version}.xcframework.zipThe
xcframeworkbundle is also now direct in the zip file as its root content, instead of being nested in a folder.Kingfisher-${version}.zip->Kingfisher-${version}/Kingfisher.xcframeworkKingfisher-${version}.zip->Kingfisher.xcframeworkThis change is for better discoverability for some package managers. However, it might break some scripts that rely on the old structure. Please update your scripts accordingly if you were relying on the old filename and zip structure.