Skip to content

[Compiler] Improve program printer #3868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 15, 2025

Conversation

turbolent
Copy link
Member

Work towards #3769

Description

To make it easier to debug compiled programs improve the program printer:

  • Optionally print instructions with their operands resolved (constant indices, type indices, function names)
  • Optionally print colorized

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Apr 14, 2025
@turbolent turbolent requested a review from SupunS as a code owner April 14, 2025 22:37
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit d610665
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@turbolent turbolent merged commit 98ba40c into feature/compiler Apr 15, 2025
7 of 9 checks passed
@turbolent turbolent deleted the bastian/improve-program-printing-2 branch May 2, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants