Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interacting with COA docs with token transfer transactions #1169

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

sisyphusSmiling
Copy link
Contributor

Closes: #1151

Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 2:28am

@sisyphusSmiling sisyphusSmiling requested review from a team, joshuahannan and briandoyle81 March 5, 2025 20:08
@sisyphusSmiling sisyphusSmiling self-assigned this Mar 5, 2025
@sisyphusSmiling sisyphusSmiling added the documentation Improvements or additions to documentation label Mar 5, 2025
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review March 5, 2025 20:38
@sisyphusSmiling
Copy link
Contributor Author

sisyphusSmiling commented Mar 5, 2025

@joshuahannan updated error messages in a4a00bb

Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -154,7 +154,8 @@ fun main(address: Address): EVM.EVMAddress {
// Borrow a reference to the COA from the storage location we saved it to
let coa = account.storage.borrow<&EVM.CadenceOwnedAccount>(
from: /storage/evm
) ?? panic("Could not borrow reference to the COA")
) ?? panic("Could not borrow reference to the signer's CadenceOwnedAccount (COA). "
.concat("Ensure the signer account has a COA stored in the canonical /storage/evm path"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have mentioned this earlier, but the simple string interpolation feature is available in the emulator, testnet, and mainnet now, so we should try to start using that from now on. I know you're busy right now, so no need to update this, but from now on when we're making new updates to error messages, lets try to use that.

@sisyphusSmiling sisyphusSmiling merged commit 09ec37b into main Mar 6, 2025
3 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/update-coa-interactions branch March 6, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add example ERC20/ERC721 transfer from COA transaction
2 participants