[Storage] Command line for badger -> pebble data migration #7413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
force-pushed
the
leo/storage-data-migration-cmd
branch
2 times, most recently
from
1342cf5 to
d865f41
Compare
zhangchiqing
force-pushed
the
leo/storage-data-migration-cmd
branch
from
c73b216 to
4d43afe
Compare
…igration-cmd-test
zhangchiqing
commented
May 23, 2025
| BatchByteSize: 32_000_000, // 32 MB | ||
| ReaderWorkerCount: 2, | ||
| WriterWorkerCount: 2, | ||
| ReaderShardPrefixBytes: 2, // better to keep it as 2. |
There was a problem hiding this comment.
benchmark shows prefixBytes: 2 took 1h11m, prefixBytes: 1 took 1h40m.
zhangchiqing
commented
May 23, 2025
Comment on lines
+16
to
+17
| ReaderWorkerCount: 2, | ||
| WriterWorkerCount: 2, |
There was a problem hiding this comment.
The worker count doesn't seem to make a big difference, 4 is the same as 2 for both reader and writer.
zhangchiqing
force-pushed
the
leo/storage-data-migration
branch
from
dd206d9 to
bfd2615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #7395
This PR adds command wrapper to call the migration function (
CopyFromBadgerToPebble) implemented in this PR