improve collection endpoints error handling #8051
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetCollectionByID GetFullCollectionByID to use access api error framework
peterargue
reviewed
Oct 24, 2025
| // TODO: transactions is not updated to use the new error handling convention | ||
| // Update this once that work is complete | ||
| return nil, err | ||
| return nil, common.ErrorToStatusError(err) |
There was a problem hiding this comment.
as noted in the comment, this endpoint isn't updated to use the new error messages, so we can't switch the error handling in this case yet.
| err = response.Build(collection, transactions, link, r.ExpandFields) | ||
| if err != nil { | ||
| return nil, err | ||
| return nil, common.ErrorToStatusError(err) |
There was a problem hiding this comment.
common.ErrorToStatusError() converts an accessSentinel error to a REST error. I don't think response.Build() calls into the backend code, so the returned error is not an accessSentinel. double check if the error returned is already wrapped. if not, you can use a specific status code error here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7649
Updated error handling for GetCollectionByID to use access api error framework.
Fixed godocs.