[Access] Add schedule tx support to rest api #8052
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
commented
Oct 18, 2025
| } | ||
|
|
||
| for _, tt := range tests { | ||
| func TestBenchmarkURLToRoute(t *testing.T) { |
There was a problem hiding this comment.
the new version completes ~25% faster (1.15s vs 1.55s)
…eduled-tx-endpoints-rest
illia-malachyn
approved these changes
Oct 23, 2025
…eduled-tx-endpoints-rest
…eduled-tx-endpoints-rest
UlyanaAndrukhiv
approved these changes
Oct 24, 2025
| return err | ||
| } | ||
|
|
||
| type GetScheduledTransaction struct { |
There was a problem hiding this comment.
Could you please add small godoc for GetScheduledTransaction, GetScheduledTransactionResult and its constructors?
| return response, nil | ||
| } | ||
|
|
||
| func isTransactionID(raw string) bool { |
There was a problem hiding this comment.
Could you please a couple of words to the godoc for isTransactionID?
| }) | ||
| } | ||
|
|
||
| func TestGetScheduledTransactions(t *testing.T) { |
There was a problem hiding this comment.
These tests look good overall! The only things I’d suggest are adding godocs for the test functions and helpers, and using .Once() to verify backend mock calls.
jordanschalm
approved these changes
Oct 27, 2025
|
|
||
| const idQuery = "id" | ||
|
|
||
| // GetTransactionByID gets a transaction by requested ID. |
There was a problem hiding this comment.
Suggested change
| // GetTransactionByID gets a transaction by requested ID. | |
| // GetTransactionByID gets a transaction by requested ID. | |
| // The ID may be either: | |
| // 1. the hex-encoded 32-byte hash of a user-submitted transaction, or | |
| // 2. the integral system-assigned identifier of a scheduled transaction |
| return response, nil | ||
| } | ||
|
|
||
| // GetTransactionResultByID retrieves transaction result by the transaction ID. |
There was a problem hiding this comment.
Suggested change
| // GetTransactionResultByID retrieves transaction result by the transaction ID. | |
| // GetTransactionResultByID retrieves transaction result by the transaction ID. | |
| // The ID may be either: | |
| // 1. the hex-encoded 32-byte hash of a user-submitted transaction, or | |
| // 2. the integral system-assigned identifier of a scheduled transaction |
Comment on lines
+138
to
+140
| // isTransactionID returns true if the provided string is a valid flow.Identifier indicating it is a | ||
| // transaction ID. | ||
| func isTransactionID(raw string) bool { |
There was a problem hiding this comment.
Suggested change
| // isTransactionID returns true if the provided string is a valid flow.Identifier indicating it is a | |
| // transaction ID. | |
| func isTransactionID(raw string) bool { | |
| // isTransactionID returns true if the provided string is a valid hex-encoded 32-byte flow.Identifier indicating it is a transaction ID. | |
| // In particular, this method returns false if the input is a *scheduled transaction* ID. | |
| func isTransactionID(raw string) bool { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for querying scheduled and system transactions using the existing
/transactions/{id}and/transaction_results/{id}endpoints.