-
Notifications
You must be signed in to change notification settings - Fork 199
Apply context lock pattern to LatestPersistedSealedResult #8082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mts1715
wants to merge
124
commits into
master
Choose a base branch
from
taras/7611-update-latestPersistedSealedResult-module-use-storage-lock
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Apply context lock pattern to LatestPersistedSealedResult #8082
mts1715
wants to merge
124
commits into
master
from
taras/7611-update-latestPersistedSealedResult-module-use-storage-lock
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]> Co-authored-by: Alexander Hentschel <[email protected]>
Co-authored-by: Alexander Hentschel <[email protected]>
Update apis to return executor metadata by reference
…er-2025-09-23 [DataAvailability] Merge master into feature/optimistic-sync 2025-09-23
…aware-events-endpoint
…ider [Access] Fix ExecutionResultInfoProvider for nodes bootstrapped after spork
…vents-endpoint [Data availability] fork aware events endpoint
…orage object introduced for optimistic sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7611
Aligns LatestPersistedSealedResult with the storage layer's context lock pattern introduced in #7364.
Changes
Updated
LatestPersistedSealedResult.BatchSet()to acceptlockctx.Proofas first parameterAdded runtime lock verification - requires caller to hold
LockInsertCollectionRemoved internal
batchMu sync.Mutexin favor of external lock management vialockctxUpdated all tests to use
storage.NewTestingLockManager()andunittest.WithLock()Updated mocks to reflect new signature
Rationale
LockInsertCollectionis used because:BatchSet()is called withinBlockPersister.Persist()which already holds this lockAll persistence operations (collections, events, results, progress) are committed in a single atomic batch
Collections storage requires
LockInsertCollectionfor transaction indexing consistencyThis ensures atomicity: either all data persists together or none