DATA-1460: Design Update of the History (Activity Stream) Page#649
DATA-1460: Design Update of the History (Activity Stream) Page#649AbiJ17 wants to merge 5 commits into
Conversation
aimalkhan
left a comment
aimalkhan
left a comment
There was a problem hiding this comment.
let's fix the translation issue.
| {% if activity.activity_type == 'new package' %} | ||
| {{ dataset_link }} dataset was created | ||
| {% elif activity.activity_type == 'changed package' %} | ||
| {% if h.lang() == 'fr' %} |
There was a problem hiding this comment.
use .po file for fr translations
There was a problem hiding this comment.
Added .po file workflow for fr translations. I also recompiled the .mo file to include the updated translations, and verified that the translations show up on the page as expected.
aimalkhan
left a comment
aimalkhan
left a comment
There was a problem hiding this comment.
Can you please check why the format changed and extra commented lines were added to the .po file? It is pretty hard to review the code like that.
| #~ msgid "Queen’s Printer for Ontario" | ||
| #~ msgstr "Imprimeur de la Reine pour l’Ontario" | ||
|
|
||
| #~ msgid "Contact Us" |
There was a problem hiding this comment.
where are these lines that are commented out coming from?
There was a problem hiding this comment.
the PR here: https://github.com/ongov/ckanext-ontario_theme/pull/547/changes does a similar addition to what we want but it does not need an entire reformat of the page. Can you try to preserve the original formatting other wise it will be really hard to review what was changes and what wasn't
There was a problem hiding this comment.
Reverted back to original version of .po file, added French translation for dataset was updated at the bottom of the file.
| msgid "Create Account" | ||
| msgstr "" | ||
|
|
||
| #~ msgid "Queen’s Printer for Ontario" |
There was a problem hiding this comment.
the "Queen's printer" is not currently being used but it is a valid translation, and we might need to use it in the future. So let's keep it.
There was a problem hiding this comment.
Seems like this is already included in the original .po file.
| msgstr "<a href=\"%(url)s\">Plus %(group_title)s</a>" | ||
|
|
||
| #: ckanext/ontario_theme/templates/internal/header.html:89 | ||
| msgid "Ministries" |
There was a problem hiding this comment.
do we not need the Ministries translation?
There was a problem hiding this comment.
When I tried to recompile the .mo file after reverting the .po file to its original version, I got a duplicate definition error and it pointed to lines 101 and 2026. There is already a Ministries translation at Line 101, so I removed the one at 2026 and kept the one at 101, after which it was able to recompile. The translation seems to show up on my end.
2 participants
What this PR accomplishes
Issue(s) addressed
What needs to be reviewed